Improved pypi support #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issed In my case this particularly affected numpy which I (for various reasons) decided to install with pypi instead of conda. The test is invoked by running 'pytest', thus setup.py adds dependency on pytest if the package is installed with the extras [test]. E.g. pip install -e .[test]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed that if I install numpy from pypi on my platform, it gets ignored in the output. This is a symptom of a general issue with this excellent addition to the conda-family of tools and here is a suggested patch and a test. This most likely fixes #10
(Apply the first commit first and see the test fail, then apply the second which fixes the issue.)