Reset requests before calling callbacks #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a callback is invoked that calls requests the previous called mock is run. When this is supposed to be a real_http request the NoMockAddress is thrown but it can't be handled in the adapter and so goes back to the outer send function. This is all a problem and for a really unusual case because almost surely if you are doing a requests call within a requests-mock callback you're trying to do a real requests call. There's no point having a callback that would simply point to something else you registered in the same adapter. So let's just assume that and reset all mocking whilst the callback code may be run. Change-Id: I9a426c54af778fcd536925744e78843854320a07
|
Moved from: https://review.openstack.org/#/c/399377/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a callback is invoked that calls requests the previous called mock
is run. When this is supposed to be a real_http request the
NoMockAddress is thrown but it can't be handled in the adapter and so
goes back to the outer send function.
This is all a problem and for a really unusual case because almost
surely if you are doing a requests call within a requests-mock callback
you're trying to do a real requests call. There's no point having a
callback that would simply point to something else you registered in the
same adapter.
So let's just assume that and reset all mocking whilst the callback code
may be run.
Change-Id: I9a426c54af778fcd536925744e78843854320a07