Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): nomatch event firing on iOS 18+ #43

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(ios): nomatch event firing on iOS 18+ #43

merged 2 commits into from
Oct 11, 2024

Conversation

jamsch
Copy link
Owner

@jamsch jamsch commented Oct 11, 2024

This PR fixes an issue where the nomatch event fires on iOS 18 due to an upstream iOS 18 issue to do with final result detection

Example event order in iOS 18:

{ isFinal: false, transcripts: ["actually", "final", "results"], metadata: { duration: 1500 } },
{ isFinal: true, transcripts: [] }

Which we translate in this library to the following events being emitted:

"result" { isFinal: true, transcripts: ["actually", "final", "results"] }
"nomatch" {}

This PR gets rid of the "nomatch" emit here

@jamsch jamsch merged commit 1da7819 into main Oct 11, 2024
2 checks passed
@jamsch jamsch deleted the fix/nomatch-event branch October 11, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant