dropped_attribute test should fail

janestreet · Feb 13, 2025 · e534780 · e534780
1 parent c4ad9e8
commit e534780
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 18 deletions.
diff --git a/test/passing/dune.inc b/test/passing/dune.inc
@@ -3503,7 +3503,8 @@
  (action
   (with-stdout-to dropped_attribute.ml.stdout
    (with-stderr-to dropped_attribute.ml.stderr
-     (run %{bin:ocamlformat} --margin-check %{dep:tests/dropped_attribute.ml})))))
+     (with-accepted-exit-codes 1
+       (run %{bin:ocamlformat} --margin-check %{dep:tests/dropped_attribute.ml}))))))
 
 (rule
  (alias runtest)
@@ -3521,7 +3522,8 @@
  (action
   (with-stdout-to dropped_attribute.ml.js-stdout
    (with-stderr-to dropped_attribute.ml.js-stderr
-     (run %{bin:ocamlformat} --profile=janestreet --enable-outside-detected-project --disable-conf-files %{dep:tests/dropped_attribute.ml})))))
+     (with-accepted-exit-codes 1
+       (run %{bin:ocamlformat} --profile=janestreet --enable-outside-detected-project --disable-conf-files %{dep:tests/dropped_attribute.ml}))))))
 
 (rule
  (alias runtest)

diff --git a/test/passing/tests/dropped_attribute.ml.err b/test/passing/tests/dropped_attribute.ml.err
@@ -0,0 +1,5 @@
+ocamlformat: ignoring "tests/dropped_attribute.ml" (syntax error)
+File "tests/dropped_attribute.ml", line 5, characters 22-31:
+5 |   val foo : (module T [@annot1] with type t = 'a [@annot2]) -> unit
+                          ^^^^^^^^^
+Error: invalid package type: an attribute cannot go here
diff --git a/test/passing/tests/dropped_attribute.ml.js-err b/test/passing/tests/dropped_attribute.ml.js-err
@@ -0,0 +1,5 @@
+ocamlformat: ignoring "tests/dropped_attribute.ml" (syntax error)
+File "tests/dropped_attribute.ml", line 5, characters 22-31:
+5 |   val foo : (module T [@annot1] with type t = 'a [@annot2]) -> unit
+                          ^^^^^^^^^
+Error: invalid package type: an attribute cannot go here
diff --git a/test/passing/tests/dropped_attribute.ml.js-ref b/test/passing/tests/dropped_attribute.ml.js-ref
@@ -1,8 +0,0 @@
-(* Attributes [[@annot1]] and [[@annot3]] are dropped by the compiler;
-   an upcoming patch should fix this. *)
-
-module _ : sig
-  val foo : ((module T with type t = 'a)[@annot2]) -> unit
-end = struct
-  let foo (type a) (module M : T with type t = a[@annot4]) = ()
-end

diff --git a/test/passing/tests/dropped_attribute.ml.ref b/test/passing/tests/dropped_attribute.ml.ref
@@ -1,8 +0,0 @@
-(* Attributes [[@annot1]] and [[@annot3]] are dropped by the compiler; an
-   upcoming patch should fix this. *)
-
-module _ : sig
-  val foo : ((module T with type t = 'a)[@annot2]) -> unit
-end = struct
-  let foo (type a) (module M : T with type t = a[@annot4]) = ()
-end

diff --git a/test/passing/tests/dropped_attribute.ml.should-fail b/test/passing/tests/dropped_attribute.ml.should-fail