Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Pexp_constraint with attributes should get parenthesized #55

Merged

Conversation

alanechang
Copy link

Made a patch upstream to fix a bug around Pexp_constraint with attributes not getting parenthesized correctly.

This PR backports the changes onto jane.

Signed-off-by: alanechang <[email protected]>
@alanechang alanechang force-pushed the aec/fix-pexp-constraint-with-attr branch from 4a41621 to 9c70aca Compare January 23, 2024 17:40
Copy link

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review this carefully but it's identical to the upstream patch reviewed by @Julow.

@ccasin ccasin merged commit ca80eda into janestreet:jane Jan 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants