improved authentication utils error messages #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GonzaFran
requested review from
colomfernando,
christian97dd and
pablodamianberdun
Pull Request Test Coverage Report for Build 13316538862Details
💛 - Coveralls |
Merged
2 tasks
…fix-authentication-utils-error-messages
…janis-commerce/oauth-native into fix-authentication-utils-error-messages
colomfernando
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXTO:
Actualmente, las 2 utilidades que utilizamos para obtener información sobre los tokens y/o la info del usuario, devuelven mensajes que no son claros y que dificultan, tanto el debuggeo como el reconocimiento de erorres reportados por el cliente.
SOLUCIÓN:
Para resolver esto e identificar más rápidamente los errores, el cambio que se hizo fue modificar los errores devueltos para que, en caso de que se muestren en pantalla al usuario, este sea más fácil de reconocer y nos permita corregirlo o dar una respuesta más rápida.
¿CÓMO SE PUEDE PROBARLO?
Para probar que el mensaje de error sea el esperado puede correr los test.
MENSAJE VISUALIZADO EN LA APP:
