Upgrade minimagick 5 #132
Merged
Upgrade minimagick 5 #132
+32
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged? |
zzak
added a commit
to zzak/rails
that referenced
this pull request
Jan 9, 2025
``` [MiniMagick] MiniMagick::Image#mime_type has been deprecated, because it wasn't returning correct result for all formats ImageMagick supports. Unfortunately, returning the correct MIME type would be very slow, because it would require ImageMagick to read the whole file. It's better to use Marcel and MimeMagic gems, which are able to determine the MIME type just from the image header. ``` This method is removed in v5 of `mini_magick` gem: > Removed deprecated Image#mime_type, as it wasn't accurate. > MIME type from file content should be determined either using Marcel > or MimeMagic, or mime-types or MiniMime using Image#type. Since we depend on it through `image_processing` gem (`mini_magick (>= 4.9.5, < 5)`), while work is being done in janko/image_processing#132 so sooner or later this test will fail.
|
I'd very much like this to be merged |
|
I'll try to get this merged this week, thanks for the work. |
mrpasquini
pushed a commit
to mrpasquini/rails
that referenced
this pull request
Jan 23, 2025
``` [MiniMagick] MiniMagick::Image#mime_type has been deprecated, because it wasn't returning correct result for all formats ImageMagick supports. Unfortunately, returning the correct MIME type would be very slow, because it would require ImageMagick to read the whole file. It's better to use Marcel and MimeMagic gems, which are able to determine the MIME type just from the image header. ``` This method is removed in v5 of `mini_magick` gem: > Removed deprecated Image#mime_type, as it wasn't accurate. > MIME type from file content should be determined either using Marcel > or MimeMagic, or mime-types or MiniMime using Image#type. Since we depend on it through `image_processing` gem (`mini_magick (>= 4.9.5, < 5)`), while work is being done in janko/image_processing#132 so sooner or later this test will fail.
|
@janko do you need someone to test this further? I had this running in a development stack for some time without issues. |
janko
approved these changes
Feb 10, 2025
|
Released 1.14.0 with this change 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using just the specs as a guide, this seems like a fairly minimal set of changes that would permit support for minimagick 5, addressing all deprecation warnings.
It also introduces distinct gemfiles for minimagick v4 and v5 which could both be run in CI. I have not yet modified the Github actions yaml to do that, but should be pretty easy to do.
A couple specs are still failing, related to the
stripcommand, but I figured it would be worth posting this to see if it seems like the right direction before spending more time on it.