-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: Multi-stage build with Node.js and Ant with Runtime in Apache/php #110
base: master
Are you sure you want to change the base?
Dockerfile: Multi-stage build with Node.js and Ant with Runtime in Apache/php #110
Conversation
…ache/PHP Using the snippets from the following work: * https://github.com/mrorgues/dockerfiles/tree/master/har_viewer_builder * https://github.com/mrorgues/dockerfiles/tree/master/har_viewer The build will make all the necessary calls, while the runtime runs Apache with PHP as it is required.
Hi @marcellodesales, thanks for this. I have a couple of similar Dockerfiles that I used to use to build/test/run HAR Viewer, but I was never confident enough in my Docker skills to push them into the repo. I also have some outstanding branches that remove the remaining Ant dependencies, so I might revisit those branches and see if I can push them before adding any Dockerfile that builds HAR Viewer using Ant. Thanks again for this, and if I can't be sure to finish the above in good time then I'll revisit your pull request without my changes. |
@gitgrimbo No problem... I have used the latest/greatest Docker build capabilities to separate the Build Image and the Runtime image... We can still decrease the size of the final image, even though it works with Apache... I would suggest starting from this point... Then we improve it... Most importantly, anyone would be able to run the Har viewer with no sweat :) |
@marcellodesales - Is it worth using jessie rather than wheezy? wheezy no longer present here - https://github.com/nodejs/docker-node/tree/master/6 |
@gitgrimbo Yeah we can change it as needed... Let me verify... |
@gitgrimbo I just updated the image and verified it is all good! |
Thanks @marcellodesales! Things have moved on a bit since you created this PR. #111 was merged to remove Ant from the build process, and I am working on this x-remove-php branch to remove PHP (feel free to try the branch [it works], but I might be force-pushing to it, so please don't rely on it yet). So ultimately, it could be that the 'builder' Dockerfile only needs NodeJS, and the 'runner' Dockerfile only needs plain Apache, rather than a PHP variant. Do you have any thoughts? |
@gitgrimbo let me know the direction... Once you merge |
Hi @marcellodesales. The removal of PHP was done in #118, so in theory a Dockerfile to build HAR Viewer would now only need node/npm installed. If you also want to run the tests, then Java would need to be installed for Selenium. |
Using the snippets from the following work:
The build will make all the necessary calls, while the runtime runs
Apache with PHP as it is required.
Build
Running