Skip to content

Commit

Permalink
Fix GRACE-2L typos (#165)
Browse files Browse the repository at this point in the history
* Update grace2l-r6.yml

fix typos

* TS declare data-files.yml types, fix target column tooltips in DiscoveryMetricsTable.svelte

---------

Co-authored-by: Janosh Riebesell <[email protected]>
  • Loading branch information
yury-lysogorskiy and janosh authored Nov 26, 2024
1 parent bff8625 commit df1efcc
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 10 deletions.
10 changes: 5 additions & 5 deletions models/grace2l_r6/grace2l-r6.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ date_added: "2024-11-21"
date_published: "2024-11-21"
authors:
- name: Anton Bochkarev
affiliation: ICAMS, Ruhr University BOchum
affiliation: ICAMS, Ruhr University Bochum
email: [email protected]
- name: Yury Lysogorskiy
affiliation: ICAMS, Ruhr University BOchum
affiliation: ICAMS, Ruhr University Bochum
email: [email protected]
- name: Ralf Drauzt
affiliation: ICAMS, Ruhr University BOchum
- name: Ralf Drautz
affiliation: ICAMS, Ruhr University Bochum
email: [email protected]
trained_by:
- name: Yury Lysogorskiy
affiliation: ICAMS, Ruhr University BOchum
affiliation: ICAMS, Ruhr University Bochum
email: [email protected]

repo: https://github.com/ICAMS/grace-tensorpotential
Expand Down
14 changes: 14 additions & 0 deletions site/src/app.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,20 @@ declare module '*model-schema.yml' {
export const ModelMetadata: import('$lib/model-schema').ModelMetadata
} // model metadata schema

declare module '*data-files.yml' {
type DataFile = {
url: string
path: string
description: string
html?: string // auto-generated after ESM import in lib/index.ts
figshare?: string
}
type DataFiles = {
[K in string]: K extends `_links` ? string : DataFile
}
export const data_files: DataFiles
}

declare module '*element-counts.json' {
const map: Record<string, number>
export default map
Expand Down
10 changes: 5 additions & 5 deletions site/src/lib/DiscoveryMetricsTable.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@
return train_size_str
}
const Targets = {
const targets_tooltips = {
E: `Energy`,
EF_C: `Energy with conservative forces`,
EF_G: `Energy with gradient-based forces`,
EF_D: `Energy with direct forces`,
EFS_C: `Energy with conservative forces and stress`,
EFS_G: `Energy with gradient-based forces and stress`,
EFS_D: `Energy with direct forces and stress`,
EFS_CM: `Energy with conservative forces, stress, and Magmoms`,
EFS_GM: `Energy with gradient-based forces, stress, and magmoms`,
EFS_DM: `Energy with direct forces, stress, and magmoms`,
}
Expand All @@ -130,7 +130,7 @@
const metrics = model.metrics?.discovery?.[discovery_set]
const targets = model.targets.replace(/_(.)/g, `<sub>$1</sub>`)
const targets_str = `<span title="${Targets[model.targets]}">${targets}</span>`
const targets_str = `<span title="${targets_tooltips[model.targets]}">${targets}</span>`
// rename metric keys to pretty labels
return {
Expand Down

0 comments on commit df1efcc

Please sign in to comment.