Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis + Lattice = Crystal #30

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Basis + Lattice = Crystal #30

merged 7 commits into from
Jan 9, 2024

Conversation

stefanbringuier
Copy link
Contributor

Details

Operation illustrating combination of a motif/basis with a point lattice to generate a crystal structure.

basis-plus-lattice

Discussion

I had a few questions on best practice for PR:

  1. It appears all that is needed is .tex and .yml files in asset/NAME-OF-TIKZ, correct?
  2. I much prefer what you've put together then trying to use figshare or Zenodo to get a DOI for various tikz figures I make, however, I'm curious if the list of contributors and the citation.cff reflect contributors with successful merged PRs? Or is attribution just given on the displayed entry obtained from the yml?

stefanbringuier and others added 7 commits January 9, 2024 00:04
Illustration showcases the formation of a crystal structure by combining a simple motif, consisting of two atoms, with a square lattice.
Details for tikz image
Remove comment details, now in yml file.
@janosh
Copy link
Owner

janosh commented Jan 9, 2024

Thanks @stefanbringuier, nice work!

It appears all that is needed is .tex and .yml files in asset/NAME-OF-TIKZ, correct?

That's right.

I'm curious if the list of contributors and the citation.cff reflect contributors with successful merged PRs?

Hadn't put any thought into that yet but we can definitely do that. Just added you to citation.cff. Let me know if your details are correct.

@janosh
Copy link
Owner

janosh commented Jan 9, 2024

Details page looks good!

Screenshot 2024-01-09 at 10 48 36

@janosh janosh added the new fig New TikZ figure label Jan 9, 2024
@janosh janosh merged commit c1e03a7 into janosh:main Jan 9, 2024
2 of 3 checks passed
@stefanbringuier
Copy link
Contributor Author

Thanks @stefanbringuier, nice work!

It appears all that is needed is .tex and .yml files in asset/NAME-OF-TIKZ, correct?

That's right.

Okay, this is great: simple and straightforward.

I'm curious if the list of contributors and the citation.cff reflect contributors with successful merged PRs?

Hadn't put any thought into that yet but we can definitely do that. Just added you to citation.cff. Let me know if your details are correct.

This is great and can't thank you enough for this resource/front-end. I have to clean-up several other TikZ figures I have but will start contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new fig New TikZ figure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants