This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Setup go-imports-organizer and organize Go imports #357
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| excludes: | ||
| - matchtype: name | ||
| regexp: ^\.git$ | ||
| - matchtype: name | ||
| regexp: ^vendor$ | ||
| groups: | ||
| - description: standard | ||
| matchorder: 3 | ||
| regexp: | ||
| - ^[a-zA-Z0-9\/]+$ | ||
| - description: kubernetes | ||
| matchorder: 1 | ||
| regexp: | ||
| - ^k8s\.io|^sigs\.k8s\.io | ||
| - description: openshift | ||
| matchorder: 2 | ||
| regexp: | ||
| - ^github\.com\/openshift | ||
| - description: other | ||
| matchorder: 4 | ||
| regexp: | ||
| - '[a-zA-Z0-9]+\.[a-zA-Z0-9]+/' | ||
| - description: module | ||
| matchorder: 0 | ||
| regexp: | ||
| - "%{module}%" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| #!/bin/bash | ||
|
|
||
| function list_go_src_files() { | ||
| find . -not \( \ | ||
| \( \ | ||
| -wholename './_output' \ | ||
| -o -wholename './.*' \ | ||
| -o -wholename '*/vendor/*' \ | ||
| \) -prune \ | ||
| \) -name '*.go' | sort -u | ||
| } | ||
|
|
||
|
|
||
| bad_files=$(list_go_src_files | xargs gofmt -s -l) | ||
| if [[ -n "${bad_files}" ]]; then | ||
| echo "!!! gofmt needs to be run on the listed files" | ||
| echo "${bad_files}" | ||
| echo "Try running 'gofmt -s -w [path]'" | ||
| exit 1 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used to run
make fmtto have the code formatted, but with this, it would just verify and exit, which is kinda surprising to me. If we are just calling./hack/verify-gofmt.sh, I would suggest renaming this Make target intoverify-fmtto make the intent clearer..I noticed that
goioalso formats the code as well, besides organizing the imports, right? So maybe this target could just be this instead:Then a separate
verify-fmttarget that would runhack/verify-gofmt.sh.WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need fmt verification at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree fmt verification might not be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coreydaley WDYT?