Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to v3 #75

Merged
merged 6 commits into from
Nov 8, 2023
Merged

migrate to v3 #75

merged 6 commits into from
Nov 8, 2023

Conversation

SteffenLm
Copy link
Contributor

@SteffenLm SteffenLm commented Nov 3, 2023

Done:

  • migrate to docusaurus v3
  • migrate slides from jsx to tsx
  • migrate configs from js to ts

Offene Punkte:

-collection Map~Author&#44&#160List~Book~~

in folgende Codes zu schreiben:

-collection Map~Author‚ List~Book~~
-collection Map~Author‚ List~Book~~
-collection Map~Author&#44&#160List~Book~~

Steffen Merk and others added 2 commits November 2, 2023 15:27
- migrate to slides from jsx to tsx
- migrate configs from js to ts
@SteffenLm SteffenLm self-assigned this Nov 3, 2023
@SteffenLm
Copy link
Contributor Author

@appenmaier
Was findest du am besten von den neuen Schreibweisen?

Und sollen wir einfach mergen oder warten, bis mermaid den fix gemerged und eine neue version gepublisht hat?

@appenmaier
Copy link
Contributor

@SteffenLm Ich würde sagen: je weniger Sonderzeichen desto besser. Daher würde ich mich für die erste Variante aussprechen.
Das Problem mit "static" sehe ich unkritisch, da wir das in den Problemfällen auch als Merkmal darstellen können. Von daher gerne mergen :-)

Copy link
Contributor

github-actions bot commented Nov 8, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-08 14:00 UTC

@SteffenLm SteffenLm merged commit e408543 into main Nov 8, 2023
@SteffenLm SteffenLm deleted the migrate-to-v3 branch November 8, 2023 13:59
@SteffenLm SteffenLm mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants