619: Ensure that background refresh only calls fn once. #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 295 297 +2
Branches 76 76
=========================================
+ Hits 295 297 +2 ☔ View full report in Codecov by Sentry. |
|
@ricall - this looks to still be failing. Any update on this? |
|
@ricall - this is fixed now. Thanks! |
garrappachc
referenced
this pull request
in tf2pickup-org/server
Dec 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cache-manager](https://togithub.com/node-cache-manager/node-cache-manager) | [`5.3.1` -> `5.3.2`](https://renovatebot.com/diffs/npm/cache-manager/5.3.1/5.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>node-cache-manager/node-cache-manager (cache-manager)</summary> ### [`v5.3.2`](https://togithub.com/node-cache-manager/node-cache-manager/releases/tag/v5.3.2) [Compare Source](https://togithub.com/node-cache-manager/node-cache-manager/compare/v5.3.1...v5.3.2) ##### What's Changed - Use a github action workflow to release new versions by [@​QuentinLemCode](https://togithub.com/QuentinLemCode) in [https://github.com/node-cache-manager/node-cache-manager/pull/612](https://togithub.com/node-cache-manager/node-cache-manager/pull/612) - adding in prepare for the build by [@​jaredwray](https://togithub.com/jaredwray) in [https://github.com/node-cache-manager/node-cache-manager/pull/618](https://togithub.com/node-cache-manager/node-cache-manager/pull/618) - fix: exclude sourcemap when package publish by [@​czy88840616](https://togithub.com/czy88840616) in [https://github.com/node-cache-manager/node-cache-manager/pull/622](https://togithub.com/node-cache-manager/node-cache-manager/pull/622) - updating clean to scripts by [@​jaredwray](https://togithub.com/jaredwray) in [https://github.com/node-cache-manager/node-cache-manager/pull/623](https://togithub.com/node-cache-manager/node-cache-manager/pull/623) - feat: support sync cache creation by [@​denkan](https://togithub.com/denkan) in [https://github.com/node-cache-manager/node-cache-manager/pull/598](https://togithub.com/node-cache-manager/node-cache-manager/pull/598) - 619: Ensure that background refresh only calls fn once. by [@​ricall](https://togithub.com/ricall) in [https://github.com/node-cache-manager/node-cache-manager/pull/620](https://togithub.com/node-cache-manager/node-cache-manager/pull/620) - updating typescript and removing release workflow by [@​jaredwray](https://togithub.com/jaredwray) in [https://github.com/node-cache-manager/node-cache-manager/pull/624](https://togithub.com/node-cache-manager/node-cache-manager/pull/624) - updating vitest to 1.1.0 by [@​jaredwray](https://togithub.com/jaredwray) in [https://github.com/node-cache-manager/node-cache-manager/pull/625](https://togithub.com/node-cache-manager/node-cache-manager/pull/625) - upgrading promise-coalesce to 1.1.2 by [@​jaredwray](https://togithub.com/jaredwray) in [https://github.com/node-cache-manager/node-cache-manager/pull/626](https://togithub.com/node-cache-manager/node-cache-manager/pull/626) - upgrading lru-cache to 10.1.0 by [@​jaredwray](https://togithub.com/jaredwray) in [https://github.com/node-cache-manager/node-cache-manager/pull/627](https://togithub.com/node-cache-manager/node-cache-manager/pull/627) - upgrading typescript and eslint to latest by [@​jaredwray](https://togithub.com/jaredwray) in [https://github.com/node-cache-manager/node-cache-manager/pull/628](https://togithub.com/node-cache-manager/node-cache-manager/pull/628) ##### New Contributors - [@​QuentinLemCode](https://togithub.com/QuentinLemCode) made their first contribution in [https://github.com/node-cache-manager/node-cache-manager/pull/612](https://togithub.com/node-cache-manager/node-cache-manager/pull/612) - [@​czy88840616](https://togithub.com/czy88840616) made their first contribution in [https://github.com/node-cache-manager/node-cache-manager/pull/622](https://togithub.com/node-cache-manager/node-cache-manager/pull/622) - [@​denkan](https://togithub.com/denkan) made their first contribution in [https://github.com/node-cache-manager/node-cache-manager/pull/598](https://togithub.com/node-cache-manager/node-cache-manager/pull/598) - [@​ricall](https://togithub.com/ricall) made their first contribution in [https://github.com/node-cache-manager/node-cache-manager/pull/620](https://togithub.com/node-cache-manager/node-cache-manager/pull/620) **Full Changelog**: jaredwray/cacheable@v5.3.0...v5.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tf2pickup-org/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #619