Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude sourcemap when package publish #622

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

czy88840616
Copy link
Contributor

@czy88840616 czy88840616 commented Dec 12, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Sourcemap files are ignored when publishing because source paths are specified in them. For example, v8 module will search for the source code path according to the sourcemap when executing the coverage command in the typescript environment. If it is not found, an error will be reported.

Just publishing the compiled js and d.ts files is enough.

like this.
image

related: midwayjs/midway#3492

@jaredwray

@czy88840616 czy88840616 changed the title fix: publish include wrong sourcemap fix: exclude sourcemap when package publish Dec 13, 2023
@jaredwray
Copy link
Owner

@czy88840616 - thanks and running the tests on this and will look to merge

@jaredwray jaredwray merged commit 17ca417 into jaredwray:master Dec 18, 2023
3 checks passed
garrappachc referenced this pull request in tf2pickup-org/server Dec 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[cache-manager](https://togithub.com/node-cache-manager/node-cache-manager)
| [`5.3.1` ->
`5.3.2`](https://renovatebot.com/diffs/npm/cache-manager/5.3.1/5.3.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/cache-manager/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cache-manager/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cache-manager/5.3.1/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cache-manager/5.3.1/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>node-cache-manager/node-cache-manager (cache-manager)</summary>

###
[`v5.3.2`](https://togithub.com/node-cache-manager/node-cache-manager/releases/tag/v5.3.2)

[Compare
Source](https://togithub.com/node-cache-manager/node-cache-manager/compare/v5.3.1...v5.3.2)

##### What's Changed

- Use a github action workflow to release new versions by
[@&#8203;QuentinLemCode](https://togithub.com/QuentinLemCode) in
[https://github.com/node-cache-manager/node-cache-manager/pull/612](https://togithub.com/node-cache-manager/node-cache-manager/pull/612)
- adding in prepare for the build by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[https://github.com/node-cache-manager/node-cache-manager/pull/618](https://togithub.com/node-cache-manager/node-cache-manager/pull/618)
- fix: exclude sourcemap when package publish by
[@&#8203;czy88840616](https://togithub.com/czy88840616) in
[https://github.com/node-cache-manager/node-cache-manager/pull/622](https://togithub.com/node-cache-manager/node-cache-manager/pull/622)
- updating clean to scripts by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[https://github.com/node-cache-manager/node-cache-manager/pull/623](https://togithub.com/node-cache-manager/node-cache-manager/pull/623)
- feat: support sync cache creation by
[@&#8203;denkan](https://togithub.com/denkan) in
[https://github.com/node-cache-manager/node-cache-manager/pull/598](https://togithub.com/node-cache-manager/node-cache-manager/pull/598)
- 619: Ensure that background refresh only calls fn once. by
[@&#8203;ricall](https://togithub.com/ricall) in
[https://github.com/node-cache-manager/node-cache-manager/pull/620](https://togithub.com/node-cache-manager/node-cache-manager/pull/620)
- updating typescript and removing release workflow by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[https://github.com/node-cache-manager/node-cache-manager/pull/624](https://togithub.com/node-cache-manager/node-cache-manager/pull/624)
- updating vitest to 1.1.0 by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[https://github.com/node-cache-manager/node-cache-manager/pull/625](https://togithub.com/node-cache-manager/node-cache-manager/pull/625)
- upgrading promise-coalesce to 1.1.2 by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[https://github.com/node-cache-manager/node-cache-manager/pull/626](https://togithub.com/node-cache-manager/node-cache-manager/pull/626)
- upgrading lru-cache to 10.1.0 by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[https://github.com/node-cache-manager/node-cache-manager/pull/627](https://togithub.com/node-cache-manager/node-cache-manager/pull/627)
- upgrading typescript and eslint to latest by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[https://github.com/node-cache-manager/node-cache-manager/pull/628](https://togithub.com/node-cache-manager/node-cache-manager/pull/628)

##### New Contributors

- [@&#8203;QuentinLemCode](https://togithub.com/QuentinLemCode) made
their first contribution in
[https://github.com/node-cache-manager/node-cache-manager/pull/612](https://togithub.com/node-cache-manager/node-cache-manager/pull/612)
- [@&#8203;czy88840616](https://togithub.com/czy88840616) made their
first contribution in
[https://github.com/node-cache-manager/node-cache-manager/pull/622](https://togithub.com/node-cache-manager/node-cache-manager/pull/622)
- [@&#8203;denkan](https://togithub.com/denkan) made their first
contribution in
[https://github.com/node-cache-manager/node-cache-manager/pull/598](https://togithub.com/node-cache-manager/node-cache-manager/pull/598)
- [@&#8203;ricall](https://togithub.com/ricall) made their first
contribution in
[https://github.com/node-cache-manager/node-cache-manager/pull/620](https://togithub.com/node-cache-manager/node-cache-manager/pull/620)

**Full Changelog**:
jaredwray/cacheable@v5.3.0...v5.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tf2pickup-org/server).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants