Basic Chromecast functionality working #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #139 (comment), I think we can move out the chromecast module to a separate app flavor which will not be built for Fdroid. It might require an overall large refactor. |
deHank
force-pushed
the
chromecastMain
branch
3 times, most recently
from
bec792c to
a743e55
Compare
|
Hey I wanted to give an update on this, I have chromecast working now + subtitles + audio track switching. |
…thod for casting videos specifically
…thod for casting videos specifically
- fixed an issue where bitrate was too high causing stuttering
- fixed an issue where bitrate was too high causing stuttering
…rovider.kt being non plural
…viously played media
- Fixed an issue with a missing implementation (coil)
|
Hey I wanted to reopen this after seeing I got tagged in discord. There are still some bugs/issues (like tracking of watched status not properly working) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'm new to using github, but I got basic chromecast functionality with subs working in the app. However certain videos with the dobly audio codec aren't working/will have no audio on some clients.
There is also a bug where it will not get subs for certain shows, but still present the option to play them.