Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add season downloads #492

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Jcuhfehl
Copy link
Contributor

@Jcuhfehl Jcuhfehl commented Aug 25, 2023

Fixes #73 and fixes #461

@Natanel-Shitrit
Copy link
Contributor

@Jcuhfehl Jcuhfehl marked this pull request as draft August 25, 2023 16:18
@Jcuhfehl
Copy link
Contributor Author

Marking as draft because I want to add a prompt to ask if the user wants to download all episodes or only unwatched ones

@Jcuhfehl Jcuhfehl marked this pull request as ready for review August 27, 2023 17:25
@Jcuhfehl
Copy link
Contributor Author

Added the prompt and fixed the linting issues, so it's ready for review

@Panda260
Copy link
Contributor

Panda260 commented Apr 3, 2024

Very, very cool and useful PR I would love to see this PR get merged! is there a time estimate when it will get merged? @jarnedemeulemeester

@EinNiki
Copy link

EinNiki commented Apr 13, 2024

Hey, why hasn't the PR feature been accepted yet?

@suyashmahar
Copy link
Contributor

Since it's been a while, i merged it locally and built it. If you want to use it, here is the link: https://drive.google.com/file/d/1eBN_y4uoGTBLc9dakjYskYKWlKTmsRVp/view?usp=sharing

@formeo14
Copy link

formeo14 commented Jul 8, 2024

Thanks for your own build.
But why isn't merged yet?

@Jcuhfehl
Copy link
Contributor Author

Jcuhfehl commented Jul 9, 2024

Thanks for your own build. But why isn't merged yet?

  1. Please be careful when downloading random apk's :)
  2. The maintainer seems quite busy so hasn't had time to merge pr's yet afaik. But that's better for him to answer himself
  3. I've made a soft-fork where I merge any pr's that I personally like/need called findroid bleeding: https://github.com/jcuhfehl/findroid which also has this pr in case you're interested. (Yes i know i just said be careful of random apk's, but this one is at least built with gh actions so you can know it's built from the actual code without any secret modifications)

@suyashmahar
Copy link
Contributor

suyashmahar commented Jul 11, 2024

Please be careful when downloading random apk's :)

Honestly, it is pretty easy to build it if you don't trust the APK and was a huge QoL improvement.

I've made a soft-fork where I merge any pr's that I personally like/need called findroid bleeding: https://github.com/jcuhfehl/findroid which also has this pr in case you're interested. (Yes i know i just said be careful of random apk's, but this one is at least built with gh actions so you can know it's built from the actual code without any secret modifications)

This is pretty cool. Thanks!

@Teravla
Copy link

Teravla commented Nov 30, 2024

Hello, guy ;)

Any News about this PR ? ;)

@formeo14
Copy link

Any News about this PR ? ;)

I don't think @jarnedemeulemeester will add it. The repository has 33 PRs, but none have been merged. It could be that he doesn't have enough time. So, I believe we'll need to wait for someone to fork the project and continue the work. It's also unfortunate that some people have invested their time in creating PRs, but they seem to be ignored. Use Findroid Bleeding it has some PRs like this merged, this PR is more then one year old.

@jarnedemeulemeester
Copy link
Owner

@Teravla @formeo14 my apologies for not being so active on GitHub.
I am currently converting the whole project from views to compose. This change will have a big impact on almost all open PRs, that's one of the reasons many have not been merged.

This PR in particular touches the UI layer which will be completely rewritten.

Also the way downloads work right now may need to completely change to be more robust. But that's a conversation for an other time.

@formeo14
Copy link

@jarnedemeulemeester, everything is fine. The current version of Findroid is working well, and with Findroid Bleeding, several PRs have been merged. I think the UI is quite good, so I wouldn't change it unless the programming becomes too difficult or could potentially cause issues in the future. However, I agree with the comment that the downloads need to be rewritten because, although the download manager works, if the phone loses connection in the last few moments I have to restart the download because it doesn't save the state of the partially downloaded file.

If you plan to make a significant UI change, could you please mention it somewhere on this Repository (e.g. a roadmap/ pinned issue) so that people who also use their free time to implement features know that their work might not be added immediately and they should wait for the UI update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to download all episodes for tv shows/series, into one button/click Downloader suggestion
9 participants