-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add season downloads #492
base: main
Are you sure you want to change the base?
Add season downloads #492
Conversation
Marking as draft because I want to add a prompt to ask if the user wants to download all episodes or only unwatched ones |
Added the prompt and fixed the linting issues, so it's ready for review |
app/phone/src/main/java/dev/jdtech/jellyfin/fragments/SeasonFragment.kt
Outdated
Show resolved
Hide resolved
app/phone/src/main/java/dev/jdtech/jellyfin/fragments/SeasonFragment.kt
Outdated
Show resolved
Hide resolved
app/phone/src/main/java/dev/jdtech/jellyfin/fragments/SeasonFragment.kt
Outdated
Show resolved
Hide resolved
app/phone/src/main/java/dev/jdtech/jellyfin/fragments/SeasonFragment.kt
Outdated
Show resolved
Hide resolved
app/phone/src/main/java/dev/jdtech/jellyfin/fragments/SeasonFragment.kt
Outdated
Show resolved
Hide resolved
Very, very cool and useful PR I would love to see this PR get merged! is there a time estimate when it will get merged? @jarnedemeulemeester |
Hey, why hasn't the PR feature been accepted yet? |
Since it's been a while, i merged it locally and built it. If you want to use it, here is the link: https://drive.google.com/file/d/1eBN_y4uoGTBLc9dakjYskYKWlKTmsRVp/view?usp=sharing |
Thanks for your own build. |
|
Honestly, it is pretty easy to build it if you don't trust the APK and was a huge QoL improvement.
This is pretty cool. Thanks! |
Hello, guy ;) Any News about this PR ? ;) |
I don't think @jarnedemeulemeester will add it. The repository has 33 PRs, but none have been merged. It could be that he doesn't have enough time. So, I believe we'll need to wait for someone to fork the project and continue the work. It's also unfortunate that some people have invested their time in creating PRs, but they seem to be ignored. Use Findroid Bleeding it has some PRs like this merged, this PR is more then one year old. |
@Teravla @formeo14 my apologies for not being so active on GitHub. This PR in particular touches the UI layer which will be completely rewritten. Also the way downloads work right now may need to completely change to be more robust. But that's a conversation for an other time. |
@jarnedemeulemeester, everything is fine. The current version of Findroid is working well, and with Findroid Bleeding, several PRs have been merged. I think the UI is quite good, so I wouldn't change it unless the programming becomes too difficult or could potentially cause issues in the future. However, I agree with the comment that the downloads need to be rewritten because, although the download manager works, if the phone loses connection in the last few moments I have to restart the download because it doesn't save the state of the partially downloaded file. If you plan to make a significant UI change, could you please mention it somewhere on this Repository (e.g. a roadmap/ pinned issue) so that people who also use their free time to implement features know that their work might not be added immediately and they should wait for the UI update? |
Fixes #73 and fixes #461