Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove cleanUpOldDownloads #529

Merged
merged 2 commits into from
Oct 28, 2023
Merged

refactor: remove cleanUpOldDownloads #529

merged 2 commits into from
Oct 28, 2023

Conversation

Natanel-Shitrit
Copy link
Contributor

@Natanel-Shitrit Natanel-Shitrit commented Sep 28, 2023 •
edited
Loading

Pretty sure enough time has passed since this was introduced and we can remove it :)

@jarnedemeulemeester jarnedemeulemeester changed the title Remove cleanUpOldDownloads refactor: remove cleanUpOldDownloads Oct 4, 2023
jarnedemeulemeester
jarnedemeulemeester requested changes Oct 4, 2023
View reviewed changes
Copy link
Owner

@jarnedemeulemeester jarnedemeulemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should remove it now. There are only a handfull of people still on an older version before the downloads rework. And those people probably cannot update because their device is running an old Android version.

I think we should also delete the appPreference downloadsMigrated variable 😄
https://github.com/jarnedemeulemeester/findroid/blob/d65591a19ec3beefc7daaf63ec6811777a41d8d7/preferences/src/main/java/dev/jdtech/jellyfin/AppPreferences.kt#L148C1-L153

@Natanel-Shitrit
Copy link
Contributor Author

Natanel-Shitrit commented Oct 5, 2023 •
edited
Loading

I agree, we should remove it now. There are only a handfull of people still on an older version before the downloads rework. And those people probably cannot update because their device is running an old Android version.

I think we should also delete the appPreference downloadsMigrated variable 😄
https://github.com/jarnedemeulemeester/findroid/blob/d65591a19ec3beefc7daaf63ec6811777a41d8d7/preferences/src/main/java/dev/jdtech/jellyfin/AppPreferences.kt#L148C1-L153

Oops, I totally forgot about that, thanks - I'll add it once I'm home!

@jarnedemeulemeester jarnedemeulemeester force-pushed the remove-downloads-migration branch from 6db858d to b05c5f1 Compare October 28, 2023 10:26
jarnedemeulemeester
jarnedemeulemeester approved these changes Oct 28, 2023
View reviewed changes
Copy link
Owner

@jarnedemeulemeester jarnedemeulemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR onto main and removed the downloadsMigrated prefrence since it was a small change I could easily commit

@jarnedemeulemeester jarnedemeulemeester merged commit 8b747bf into jarnedemeulemeester:main Oct 28, 2023
2 checks passed
@Natanel-Shitrit Natanel-Shitrit deleted the remove-downloads-migration branch October 28, 2023 10:40
@Natanel-Shitrit
Copy link
Contributor Author

I rebased the PR onto main and removed the downloadsMigrated prefrence since it was a small change I could easily commit

Thank you 🙏
I'm sorry I wasn't able to complete this PR.

Hard times - hope to return supporting Findroid soon ♥️

@jarnedemeulemeester
Copy link
Owner

Thank you 🙏 I'm sorry I wasn't able to complete this PR.

Hard times - hope to return supporting Findroid soon ♥️

No problem man! I haven't been able to do much myself either.

Take care ♥️

olebeck pushed a commit to olebeck/findroid that referenced this pull request Nov 9, 2023
@Natanel-Shitrit @jarnedemeulemeester @olebeck
refactor: remove cleanUpOldDownloads (jarnedemeulemeester#529)
7c8f8a1 
* Remove `cleanUpOldDownloads`

* refactor: remove `downloadsMigrated` preference

---------

Co-authored-by: Jarne Demeulemeester <[email protected]>
ghost pushed a commit to pruthvi-21/findroid that referenced this pull request Jul 22, 2024
@Natanel-Shitrit @jarnedemeulemeester
refactor: remove cleanUpOldDownloads (jarnedemeulemeester#529)
cd2853f 
* Remove `cleanUpOldDownloads`

* refactor: remove `downloadsMigrated` preference

---------

Co-authored-by: Jarne Demeulemeester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnedemeulemeester jarnedemeulemeester jarnedemeulemeester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Natanel-Shitrit @jarnedemeulemeester