Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings navigation fixes #714

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

leekleak
Copy link
Contributor

@leekleak leekleak commented Apr 3, 2024

The pr addresses all settings sub menus except "Servers", "Users" and "Addresses" (Because they are already working as expected).
Changes for all the other sub menus:

  • Entering and exit animations are now consistent across all sub menus.
  • Pressing the back button in the header returns to the main settings menu instead of returning to home.
  • Header label now correctly states the sub menu name instead of just saying "Settings"

P.S. Previously the animations for the changed sub menus were "slide in/out" whereas now they're "fade in/out". Not sure if this is better, maybe I should change them all to be "slide in/out"?

@Panda260
Copy link
Contributor

Oh very nice especially when you go back with the arrow you don't end up on the home screen but actually go back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants