-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Transcoding stream in player selection + Transcoded downloads #791
base: main
Are you sure you want to change the base?
feat: Transcoding stream in player selection + Transcoded downloads #791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice (although I didn't test it yet). I noticed a few things that could be improved.
Also I think adding a transcoded 1080p (maybe even a 4k one) would be useful. People may store 4k BDRemuxes, so getting a stream that's not full blu-ray bitrate would often be needed in that case.
Graphic Subtitles don't work when transcoding playback, that is quite an issue... |
hey, thanks for testing! for PSGSUB I noticed I never get a deliveryurl for this specific codec only. not sure why the path is always null. However there is one more thing i would like to try. As for audio tracks there is no logic to handle extra audio tracks yet. I haven't even thought about it, I will need to have a look. |
If it gets transcoded anyway, why not just add a way to deselect certain audio tracks from being downloaded? |
Just to let you know, I have been looking at this PR from time to time. |
Any chance this gets merged soon? Streamyfin has a similar transcode download feature but IMO Findroid is a much better UI. It was posted on this jellyfin feature request that has been open for 5 years with over 300 upvotes. I imagine many of those people would love to see they have multiple mobile app options for transcoding offline downloads. |
Transcoded stream support (Auto(adaptive) - Original - 1080p - 720p - 480p - 360p)
Transcoded download support (Original - 1080p - 720p - 480p - 360p)
Fully working transcoded stream
Embedded subtitle in transcoded stream
Transcoded download (Original - 720p - 480p - 360p)
Adding embedded subtitle tracks externally when playing offline
App preference for download quality
Dialog to pick download quality when download if default is not set
TODO:
Enum commits changes 1 2
Apks
Closes
#775
#43