Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transcoding stream in player selection + Transcoded downloads #791

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nomadics9
Copy link
Contributor

@nomadics9 nomadics9 commented Jul 18, 2024

  • Transcoded stream support (Auto(adaptive) - Original - 1080p - 720p - 480p - 360p)

  • Transcoded download support (Original - 1080p - 720p - 480p - 360p)

  • Fully working transcoded stream

  • Embedded subtitle in transcoded stream

  • Transcoded download (Original - 720p - 480p - 360p)

  • Adding embedded subtitle tracks externally when playing offline

  • App preference for download quality

  • Dialog to pick download quality when download if default is not set

TODO:

  • Enum -> commit commit
  • Strings + icon name -> commit
  • Rework getting OriginalHeight for quality selection dialog -> commit
  • Add option to choose between h265(HEVC) or h264 to transcode into -> commit
  • Code clean up -> commit

Enum commits changes 1 2

  • New Enum "VideoQuality"
  • Add Resolution 1080p
  • Bitrates values change -> 1080p - 8Mbps | 720p - 3Mbps | 480p - 1.5Mbps | 360p 800Kbps
  • All transcodes to H264 and AAC-128k
  • Bugfix causing unprivileged users not able to change stream quality
  • Show selected quality selection dialog

Apks

Closes

#775
#43

Copy link
Contributor

@Jcuhfehl Jcuhfehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice (although I didn't test it yet). I noticed a few things that could be improved.
Also I think adding a transcoded 1080p (maybe even a 4k one) would be useful. People may store 4k BDRemuxes, so getting a stream that's not full blu-ray bitrate would often be needed in that case.

@UriSheinman
Copy link

UriSheinman commented Jul 20, 2024

Graphic Subtitles don't work when transcoding playback, that is quite an issue...
Edit:
In general subtitles and track selection is kinda all over the place, sometimes it shows options sometimes it doesn't, sometimes it shows track's language and sometime it doesn't. Also there's no indicator in the quality selection as to what is selected. There should be a checkmark or something...

@nomadics9
Copy link
Contributor Author

nomadics9 commented Jul 20, 2024

Graphic Subtitles don't work when transcoding playback, that is quite an issue... Edit: In general subtitles and track selection is kinda all over the place, sometimes it shows options sometimes it doesn't, sometimes it shows track's language and sometime it doesn't. Also there's no indicator in the quality selection as to what is selected. There should be a checkmark or something...

hey, thanks for testing! for PSGSUB I noticed I never get a deliveryurl for this specific codec only. not sure why the path is always null. However there is one more thing i would like to try.

As for audio tracks there is no logic to handle extra audio tracks yet. I haven't even thought about it, I will need to have a look.

@nomadics9 nomadics9 changed the title feat: Transcoding stream in player selection + Transcoded downloads (WIP)feat: Transcoding stream in player selection + Transcoded downloads Jul 20, 2024
@nomadics9 nomadics9 changed the title (WIP)feat: Transcoding stream in player selection + Transcoded downloads feat: Transcoding stream in player selection + Transcoded downloads Jul 20, 2024
@MarkusTieger
Copy link

If it gets transcoded anyway, why not just add a way to deselect certain audio tracks from being downloaded?
Also would be nice to have a way to change that: "All transcodes to H264 and AAC-128k"
(haven't tried the apk, just assumptions from the issue description)

@jarnedemeulemeester
Copy link
Owner

Just to let you know, I have been looking at this PR from time to time.
Once I have a little more time to spare I will take a look at it in more detail.

@NickLewanowicz
Copy link

Any chance this gets merged soon? Streamyfin has a similar transcode download feature but IMO Findroid is a much better UI.

It was posted on this jellyfin feature request that has been open for 5 years with over 300 upvotes. I imagine many of those people would love to see they have multiple mobile app options for transcoding offline downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants