-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compatibility with find package #181
fix compatibility with find package #181
Conversation
Can you explain the problem that you're fixing here? |
Oh sorry about the lack of details. This PR fixes 2 problems and adds 1 feature.
Where two parts of a project can depend on cxxopts and cxxopts is embedded in the library. With the current master commit I couldn't get my libraries to
|
I don't know how all of this works because I'm not very familiar with cmake, but something doesn't look right here:
|
Just to confirm, do you mean these two lines? |
Yes. I don't expect something to be installed in the root directory when giving a prefix in my home directory. In general an arbitrary user probably can't do that anyway. |
e624de7
to
80bdf93
Compare
I had forgotten the line
Which defines the
|
@jarro2783 Anything I can do to help this get merged in? |
Sorry I forgot about this one. Can you rebase first? |
This preserves behaviour with the add_subdirectory stuff.
This change is