Skip to content

Commit

Permalink
Disable failing tests (sample websites not having the same error)
Browse files Browse the repository at this point in the history
  • Loading branch information
Adrien Rey-Jarthon committed Nov 24, 2020
1 parent 130e77c commit 4706d89
Showing 1 changed file with 16 additions and 12 deletions.
28 changes: 16 additions & 12 deletions test/ssl-test_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@
_(cert).must_be_instance_of OpenSSL::X509::Certificate
end

it "returns no error when no CN" do
valid, error, cert = SSLTest.test("https://no-common-name.badssl.com/")
_(error).must_be_nil
_(valid).must_equal true
_(cert).must_be_instance_of OpenSSL::X509::Certificate
end
# Expired for the moment https://github.com/chromium/badssl.com/issues/447
#
# it "returns no error when no CN" do
# valid, error, cert = SSLTest.test("https://no-common-name.badssl.com/")
# _(error).must_be_nil
# _(valid).must_equal true
# _(cert).must_be_instance_of OpenSSL::X509::Certificate
# end

it "works with websites blocking http requests" do
valid, error, cert = SSLTest.test("https://obyava.ua")
Expand Down Expand Up @@ -102,11 +104,13 @@
_(cert).must_be_instance_of OpenSSL::X509::Certificate
end

it "warns when the authorityInfoAccess extension is missing" do
valid, error, cert = SSLTest.test("https://www.anonymisation.gov.pf")
_(error).must_equal "OCSP test couldn't be performed: Missing authorityInfoAccess extension"
_(valid).must_equal true
_(cert).must_be_instance_of OpenSSL::X509::Certificate
end
# Not the same error any more, I didn't find another certificate in this situation
#
# it "warns when the authorityInfoAccess extension is missing" do
# valid, error, cert = SSLTest.test("https://www.anonymisation.gov.pf")
# _(error).must_equal "OCSP test couldn't be performed: Missing authorityInfoAccess extension"
# _(valid).must_equal true
# _(cert).must_be_instance_of OpenSSL::X509::Certificate
# end
end
end

0 comments on commit 4706d89

Please sign in to comment.