Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace time.sleep() with asyncio.sleep() #192

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CashWilliams
Copy link

Attempt to fix #172, #178, and #191.

Losely based on #173, but using asyncio.sleep instead of task.sleep.

It should be noted I have no idea what I'm doing 😃

@ollo69
Copy link
Collaborator

ollo69 commented Jan 1, 2023

You cannot make async a function that perform sync activities just because you want to call 1 async method. You are mixing sync and async, this is totally wrong and would be worst that original implementation.

@koen241
Copy link

koen241 commented Jan 26, 2023

Indeed did not fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected blocking call inside the event loop.
3 participants