This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
Changes in Dockerfile #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the yara.lock will be generated during the build and pm2 will also be added in the dependencies, Signed-off-by: G0R1LL4 <[email protected]>
Signed-off-by: G0R1LL4 <[email protected]>
bumped the version by x.1.x Signed-off-by: G0R1LL4 <[email protected]>
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@90r1ll4 We use Bun, not Yarn |
@j-dogcoder But in DockerFile it was setup to use yarn, Should i rewrite it using bun? |
|
Yes please!
… On Oct 12, 2022, at 11:29 AM, G0R1LL4 ***@***.***> wrote:
@90r1ll4 <https://github.com/90r1ll4> We use Bun, not Yarn
But in DockerFile it was setup to use yarn, Should i rewrite it using bun?
—
Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APV5WOAGPUTCKAOX4IT2OATWC3KN7ANCNFSM6AAAAAARDGPSRE>.
You are receiving this because you commented.
|
Signed-off-by: Ashwin Singh <[email protected]>
Signed-off-by: Ashwin Singh <[email protected]>
|
@j-dogcoder re-wrote dockerfile added pm2 bun e.t.c , no errors in dockerfile , can't test it due to creds. |
|
I will test that now. |
|
@j-dogcoder sure, let me know if any issue |
jaspermayone
approved these changes
Oct 17, 2022
|
already marked |
|
@j-dogcoder thanx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The bun, node js will be installed and file will be create during the build and pm2 is also include now
Related Issue
Closes #157
Version
Did you remember to update the version number in the package.json file?
Documentation
For any version updates, please verify if the documentation page needs an update. If it does, please update the in code docs to ensure it is not forgotten.