Ensure that ping threads are closed when the ServerApp finishes. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the thread might keep running and evend send pings on a wrong file descriptor. The reason is that file descriptors seem to be re-used by the system. Now, if the ping thread sleeps during such a re-connect and re-use of a file descriptor, it will simply keep pinging and tickling on the new connection. This can easily lead to a lot of threads that won't terminate.
|
@moesenle Thanks! Have you been testing this patch on some staging/production system? |
|
@jaspervdj , thanks for merging it! Yes, we are using the patch already and it seems to work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the thread might keep running and even send pings on a wrong file descriptor. The reason is that file descriptors seem to be re-used by the system. Now, if the ping thread sleeps during such a re-connect and re-use of a file descriptor, it will simply keep pinging and tickling on the new connection. This can easily lead to a lot of threads that won't terminate.
This most likely fixes #21 and #10.