support multiple architectures (e.g. SSE, AVX) in the same executable…

[JeffMcClintock]

… via a macro

[jatinchowdhury18]

Suggested change

	target_compile_definitions(RTNeural
	PRIVATE
	RTNEURAL_NAMESPACE=RTNeural
	)
	set(RTNEURAL_NAMESPACE "RTNeural" CACHE STRING "Namespace to use for RTNeural code")
	target_compile_definitions(RTNeural
	PUBLIC
	RTNEURAL_NAMESPACE=${RTNEURAL_NAMESPACE}
	)

I was thinking it might make sense to do this through a CMake variable, just to be a little more transparent?
I think I'd also prefer the namespace definition to be public so that user-space code can also use RTNEURAL_NAMESPACE if needed, but maybe that could cause other issues?

[JeffMcClintock]

thanks. Done.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37fde44) 95.64% compared to head (fab98d1) 95.64%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          58       58           
  Lines        3860     3860           
=======================================
  Hits         3692     3692           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jatinchowdhury18]

Ah, I hadn't thought about this... maybe instead it would be better to have something at the top of "RTNeural.h" like:

#ifndef RTNEURAL_NAMESPACE
#define RTNEURAL_NAMESPACE RTNeural
#endif

That way folks currently using RTNeural without CMake won't have a breaking change.

[JeffMcClintock]

smart. I've pushed a new commit.

[jatinchowdhury18]

Awesome, thanks again! Merging now...