Add MathsProvider to template for dynamic model loading #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this is a good solution to the problem we were talking about, for run-time model architectures... Would you mind adding the template parameter forwarding for the GRU layer, and relevant Activation layers as well? |
|
Done (I think). |
|
Perfect. Thanks for the contribution! |
jatinchowdhury18
merged commit f2b61e5
into
jatinchowdhury18:main
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the MathsProvider template parameter for the dynamic model json parser. I wired it up so that it gets used for LSTM layer creation - other layers may also need it.