off by one errors

javagrunt-com · Feb 7, 2024 · d48f7ff · d48f7ff
1 parent 633c18a
commit d48f7ff
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/main/java/com/javagrunt/service/gateway/Application.java b/src/main/java/com/javagrunt/service/gateway/Application.java
@@ -83,20 +83,17 @@ class RequestCountingFilter implements GatewayFilter, ScalerService {
 
 	@Override
 	public long getMetric(String name, String namespace) {
-		AtomicInteger count = getCount(name, namespace);
-		logger.info("Returning count: " + count.get());
-		return count.get();
+		return getCount(name, namespace).get();
 	}
 
 	@Override
 	public boolean isActive(String name, String namespace) {
-		AtomicInteger count = getCount(name, namespace);
-		logger.info("Returning active: " + (count.get() > 0));
-		return count.get() > 0;
+		return getCount(name, namespace).get() > 0;
 	}
 
 	@Override
 	public void setActive(String name, String namespace, boolean active) {
+		logger.info("Setting active: " + active);
 		AtomicInteger count = getCount(name, namespace);
 		if(count.get() > 0){
 			count.set(0);
@@ -110,6 +107,7 @@ public Mono<Void> filter(ServerWebExchange exchange, GatewayFilterChain chain) {
         String name = r.getMetadata().get("name").toString();
 		String namespace = r.getMetadata().get("namespace").toString();
 		AtomicInteger count = getCount(name, namespace);
+		logger.info("Incrementing count");
 		count.incrementAndGet();
 		return this.filter.filter(exchange, chain).doOnError(e -> {
 			if (count.get() > 0) {