fix: improved error handling around dice roller

javalent · Dec 8, 2021 · b0058c6 · b0058c6
1 parent 9e29bda
commit b0058c6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/view/Statblock.svelte b/src/view/Statblock.svelte
@@ -27,8 +27,8 @@
     export let canSave: boolean;
 
     let canExport = monster.export ?? plugin.settings.export;
-    let canDice = monster.dice ?? plugin.settings.useDice;
-
+    let canDice =
+        plugin.canUseDiceRoller && (monster.dice ?? plugin.settings.useDice);
     let canRender = monster.render ?? plugin.settings.renderDice;
 
     setContext<StatBlockPlugin>("plugin", plugin);

diff --git a/src/view/ui/DiceRoll.svelte b/src/view/ui/DiceRoll.svelte
@@ -8,6 +8,8 @@
     export let text: string;
     export let original: string | number = text;
 
+    const dice = getContext<boolean>("dice");
+
     const plugin = getContext<StatBlockPlugin>("plugin");
     const render = getContext<boolean>("render");
 
@@ -23,7 +25,7 @@
     });
 
     let roller: StackRoller = null;
-    if (!roller && plugin.canUseDiceRoller) {
+    if (!roller && dice) {
         roller = plugin.getRoller(`${text}`) as StackRoller;
     }
 
@@ -56,12 +58,16 @@
     });
 
     const rollerEl = (node: HTMLElement) => {
-        node.appendChild(roller.containerEl);
+        if (!roller || !roller.containerEl) {
+            node.setText(`${original}`);
+        } else {
+            node.appendChild(roller.containerEl);
+        }
     };
 </script>
 
 {#key error}
-    {#if error}
+    {#if error || !dice}
         {text}
     {:else}
         <span class="roller-result" use:rollerEl />