-
Notifications
You must be signed in to change notification settings - Fork 37
πβ¨ Add Full PHP 8.4 Support ππ§π₯ #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
francescobianco
wants to merge
18
commits into
main
Choose a base branch
from
imap-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Hi @francescobianco! We have detected an error in the use of the library by SinergiaCRM in the In case it's helpful, we've resolved it for now by checking that the property the function receives is not null using the following code:
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This issue is to officially track and implement support for PHP 8.4 across the
php-imap2
library.With PHP 8.4 introducing several changes (deprecations, strictness improvements, internal API adjustments), it's crucial to make sure
php-imap2
stays compatible and stable moving forward.Checklist:
composer.json
to allowphp: ^8.4
v2.x.x
orv3.0.0
depending on BC impact)Context:
imap_*
functions under PHP 8.4Note:
If youβre already running PHP 8.4 and encounter any issues, please comment below with:
php -v
)Letβs keep this library future-proof and blazing fast! πππ