Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript specials #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Onxi95
Copy link

@Onxi95 Onxi95 commented May 30, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 30, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@deivuss331 deivuss331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make requested changes. Thank you!

```

Usually, a line-break is also treated as a delimiter, so that would also work:
Zwykle znak końca wiersza jest również traktowany jako separator, więc to działałby również:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misspell in "działałby" word. Shouldn't it be "działałoby"?


[1, 2].forEach(alert)
```

Most codestyle guides agree that we should put a semicolon after each statement.
Większość wytycznych do stylów kodowania (ang. *codestyle guides*) twierdzi, że po każdym wyrażeniu należy umieścić średnik.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add any phrases that weren't originally in sentence.
I'd also consider changing "Większość wytycznych do stylów kodowania" for "Większość styli kodowania" as it changes the original meaning IMO.


[`alert(message)`](mdn:api/Window/alert)
: Output a `message`.
[`alert(wiadomość)`](mdn:api/Window/alert)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not modify any variable names


All these functions are *modal*, they pause the code execution and prevent the visitor from interacting with the page until they answer.
Wszystkie te funkcje są *modalne* (w postaci okien dialogowych), wstrzymują wykonywanie kodu i uniemożliwiają odwiedzającemu interakcję ze stroną, dopóki nie odpowie.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add any special phrases like this one: "(w postaci okien dialogowych)"

Logical operators
: Logical AND `&&` and OR `||` perform short-circuit evaluation and then return the value where it stopped (not necessary `true`/`false`). Logical NOT `!` converts the operand to boolean type and returns the inverse value.
Operatory logiczne
: Logiczne ORAZ (ang. *AND*) `&&` i LUB (ang. *OR*) `||` wykonują ewaluację w postaci "zwarcia" (ang. *short-circuit evaluation*) a następnie zwracacją wartość w miejscu, w którym została zatrzymana (niekoniecznie`true`/`false`). Logiczne NIE (ang. *NOT*) `!` Konwertuje operand na typ boolowski i zwraca wartość odwrotną.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add any special phrares like: (ang. OR)


1. Function Declaration: the function in the main code flow
1. Function Declaration: funkcja w głównym przepływie kodu (ang. *code flow*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove fragment that wasn't originally in sentence: (ang. code flow)

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants