Skip to content

Commit

Permalink
[HWORKS-1805] Increase timeouts for starting/stopping deployments (lo…
Browse files Browse the repository at this point in the history
  • Loading branch information
javierdlrm committed Nov 14, 2024
1 parent 5b41de1 commit be45a0b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions python/hsml/deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def __init__(
self._model_registry_id = None

@usage.method_logger
def save(self, await_update: Optional[int] = 60):
def save(self, await_update: Optional[int] = 120):
"""Persist this deployment including the predictor and metadata to Model Serving.
# Arguments
Expand All @@ -79,7 +79,7 @@ def save(self, await_update: Optional[int] = 60):
self._serving_engine.save(self, await_update)

@usage.method_logger
def start(self, await_running: Optional[int] = 60):
def start(self, await_running: Optional[int] = 120):
"""Start the deployment
# Arguments
Expand All @@ -91,7 +91,7 @@ def start(self, await_running: Optional[int] = 60):
self._serving_engine.start(self, await_status=await_running)

@usage.method_logger
def stop(self, await_stopped: Optional[int] = 60):
def stop(self, await_stopped: Optional[int] = 120):
"""Stop the deployment
# Arguments
Expand Down
6 changes: 3 additions & 3 deletions python/tests/test_deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def test_save_default(self, mocker, backend_fixtures):
d.save()

# Assert
mock_serving_engine_save.assert_called_once_with(d, 60)
mock_serving_engine_save.assert_called_once_with(d, 120)

def test_save(self, mocker, backend_fixtures):
# Arrange
Expand Down Expand Up @@ -176,7 +176,7 @@ def test_start_default(self, mocker, backend_fixtures):
d.start()

# Assert
mock_serving_engine_start.assert_called_once_with(d, await_status=60)
mock_serving_engine_start.assert_called_once_with(d, await_status=120)

def test_start(self, mocker, backend_fixtures):
# Arrange
Expand Down Expand Up @@ -207,7 +207,7 @@ def test_stop_default(self, mocker, backend_fixtures):
d.stop()

# Assert
mock_serving_engine_stop.assert_called_once_with(d, await_status=60)
mock_serving_engine_stop.assert_called_once_with(d, await_status=120)

def test_stop(self, mocker, backend_fixtures):
# Arrange
Expand Down

0 comments on commit be45a0b

Please sign in to comment.