Add an example demonstrating input-output aliasing with the FFI #25042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhulenev
reviewed
Nov 21, 2024
| // after their first use. | ||
|
|
||
| ffi::Error CounterImpl(int64_t index, ffi::ResultBufferR0<ffi::S32> out) { | ||
| static std::mutex mutex; |
There was a problem hiding this comment.
Oh, how I'd love to see it converted to FFI state :)
|
Can you rebase on main once #25041 is in please? |
dfm
force-pushed
the
ffi-example-input-output-alias
branch
from
9b73593 to
a554537
Compare
|
@superbobry — I lost track of this, but found it when going through my backlog! Rebased. Please take a look when you get a chance. Thanks!! |
superbobry
approved these changes
Jan 7, 2025
google-ml-butler
bot
added
kokoro:force-run
pull ready
dfm
force-pushed
the
ffi-example-input-output-alias
branch
from
a554537 to
62656b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diffbase #25041
As requested in #24986, this PR adds an FFI example that uses input-output aliasing.
Fixes #24986
Edited to add: This is the relevant diff: dfm/jax@ffi-example-refactor...ffi-example-input-output-alias