[CI] Allow any python version for pre-commit

[sergey-kozub]

Currently "pre-commit" doesn't work if python3.9 is not installed (e.g. on a typical Ubuntu which has python3.12)

[sergey-kozub]

@jakevdp Github doesn't allow me to assign reviewers to this PR - is this intended?

[jakevdp]

Thanks - I wonder if this change will cause flakiness across systems? My understanding is that this not only controls the python version used to run the hook, but also the precise set of rules enforced by pyink. Do you know if that's right?

[jakevdp]

From the PyInk docs:

        # It is recommended to specify the latest version of Python
        # supported by your project here, or alternatively use
        # pre-commit's default_language_version, see
        # https://pre-commit.com/#top_level-default_language_version
        language_version: python3.9

Perhaps we should use python3.12 here instead?

[sergey-kozub]

My understanding is that this not only controls the python version used to run the hook, but also the precise set of rules enforced by pyink. Do you know if that's right?

I checked pyink sources, and the python version defines the set of features supported by the language version:
https://github.com/google/pyink/blob/eebe6ee90e6d57d9276303614ac5e640f2ff79d3/src/pyink/mode.py#L141

This set is backwards compatible, i.e. features are only added, not removed, so I believe bumping the version up to 3.12 should be safe from pyink perspective.

[sergey-kozub]

Perhaps we should use python3.12 here instead?

Updated the PR.

[jakevdp]

It looks like we'll also need to update the Python version for the lint job in the test.yml file:

ml_dtypes/.github/workflows/test.yml

Lines 16 to 24 in b65a1f6

	lint:
	runs-on: ubuntu-latest
	steps:
	- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # ratchet:actions/checkout@v4
	- name: Set up Python 3.9
	uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # ratchet:actions/setup-python@v5
	with:
	python-version: 3.9
	- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # ratchet: pre-commit/action@v3

[sergey-kozub]

It looks like we'll also need to update the Python version for the lint job in the test.yml file:

Good catch, I haven't noticed this.
How do I test the change? There are some "ratchet" hashes around these lines, I'm not sure if those should also be updated.

[jakevdp]

Thanks!

[jakevdp]

There was a problem with pulldown. Could you rebase on main to trigger a new job?

[sergey-kozub]

There was a problem with pulldown. Could you rebase on main to trigger a new job?

Rebased on main.