-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added German translation and hassfest validator for custom integrations #21
Conversation
Thanks @jwiesel I hadn't seen that hassfest validator before looks great. Just the conflicts from the other PR's already being merged. Also If you can update both en and ge granslations about the IP address, WiCAN supports mDNS now, and thats the method we should be encourging people to use, removes the need for a static IP |
@jwiesel also just invited you as collabirator, you've done just as bout as much as I have for this now, and will be able to list you as codeowner for getman translation for future changes to it and if your interested to help review for other PR's by others in the future |
Stolen from #21 just wanted this in asap
@jwiesel just put in the hassfest validator directly now, was keen to get that running and see how it worked before the german translation was updated |
Hi @jay-oswald , Regarding mDNS: I tested connecting to WiCAN using the mDNS-name, but ran into issues.
Therefore I'd leave the mDNS part out of this translation PR for now. When we get mDNS to work, we can update the translations as well. |
Just a minor one: