Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added German translation and hassfest validator for custom integrations #21

Merged
merged 9 commits into from
Feb 26, 2025

Conversation

jwiesel
Copy link
Collaborator

@jwiesel jwiesel commented Feb 14, 2025

Just a minor one:

  • Adding a German translation
  • Minor updates in strings
  • Included the hassfest validator for custom HomeAssistant components.

@jay-oswald
Copy link
Owner

Thanks @jwiesel I hadn't seen that hassfest validator before looks great. Just the conflicts from the other PR's already being merged.

Also If you can update both en and ge granslations about the IP address, WiCAN supports mDNS now, and thats the method we should be encourging people to use, removes the need for a static IP

@jay-oswald
Copy link
Owner

@jwiesel also just invited you as collabirator, you've done just as bout as much as I have for this now, and will be able to list you as codeowner for getman translation for future changes to it and if your interested to help review for other PR's by others in the future

jay-oswald added a commit that referenced this pull request Feb 25, 2025
Stolen from #21 just wanted this in asap
@jay-oswald
Copy link
Owner

@jwiesel just put in the hassfest validator directly now, was keen to get that running and see how it worked before the german translation was updated

@jwiesel
Copy link
Collaborator Author

jwiesel commented Feb 25, 2025

Hi @jay-oswald ,
thanks for the invitation. I just accepted. Happy to contribute! :-)

Regarding mDNS: I tested connecting to WiCAN using the mDNS-name, but ran into issues.
There are also some discussions around it:

  1. in context of HomeAssistant: Cannot specify powerview-g3.local as the hub address during setup home-assistant/core#134364
  2. in context of aiohttp: aiodns does not work with mDNS and is the default resolver aio-libs/aiohttp#10186

Therefore I'd leave the mDNS part out of this translation PR for now. When we get mDNS to work, we can update the translations as well.

@jay-oswald jay-oswald merged commit 75bece0 into jay-oswald:main Feb 26, 2025
1 check passed
@jwiesel jwiesel deleted the german-translation branch February 26, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants