Add a few tests for letra.js and options button #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do think there's still value in testing the templates! Mostly just to make sure that everything is still working the way that it's supposed to. As for Jest not covering these, it's probably okay for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got bored and ended up writing a few tests already for #124. 😂 Noticed some interesting things while doing this... Looks like the code coverage reporter is not picking up anything in the components folder for the client. After doing some poking around jest appears to be ignoring these files because they have no methods.
Which leads me to my next question. Do you see value in template tests @jayehernandez? Almost all the tests I wrote for the options button involve the template. Checking to make sure a css class is there, testing a button click event, etc. These tests won't get reflected in the code coverage but I think they could still be useful tests. Was curious what your opinion on it might be?