Feature/letra 95 - Add remaining tests for component buttons, add router tests, and add store tests #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion into feature/letra-95
There was a problem hiding this comment.
Just have one comment but the rest of the file looks good! Thanks for changing the structure of the store as well.
I have no experience with mocking requests but I think you did a good job for the chrome storage. Thanks for all your work on this @tbarland77. I've been learning a lot about tests through your PRs.
|
Thanks! Glad to hear you're learning more about tests through my PR's. It definitely took a while testing the store but I learned quite a bit especially in regards to testing promises. Hopefully, before long now Letra will have full code coverage. 😃 |
|
Yes to full code coverage. 🥳 I think this PR is good to go, thank you once again @tbarland77! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jayehernandez, it took a while but I have another PR for #124. I made the following changes:
Added tests for the remaining component buttons (random button and translate button)
Removed tests that were only testing the component name as those were causing deprecation warnings
Added tests for the router
Added tests for the store
Refactored/modified the store slightly to export the actions and mutations so I could easily import them in the test file
There's a decent bit here especially in the store test file as there was quite a bit of mocking I had to do. That file could probably be a bit cleaned up as well. Anyway, I just wanted to go ahead and open this PR so you could have a look. Let me know what you think!