-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thai language #336
Add thai language #336
Conversation
🌍 Add a Language #1 |
Can anyone help me with the check fail (🚥 Test / build (pull_request)) |
Hey, @itzmeowww take a look at this log. There seems to be some issue with the |
@Kvaibhav01 Thanks, it was caused by my text formatting. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this out, @itzmeowww! Just wondering about the changes in the README file aside from adding Thai to the supported languages? It's causing some merge conflicts
Ohh, I will try to fix it. |
@jayehernandez I think it is caused by the ALL-CONTRIBUTORS-BADGE part. |
Thank you for contributing to Letra ☀️, @itzmeowww!! Appreciate your contribution to this open source project. 🥳 I'll be including the addition of Thai in the next release! Continue supporting Letra by:
|
@all-contributors please add @itzmeowww for translation |
I've put up a pull request to add @itzmeowww! 🎉 |
Hi, @itzmeowww @jayehernandez I think incrementing the currentLanguagesCount is not done as part of this pull request. Could you please confirm? So that I can make the relevant change for the Tamil language pull request #376 |
@itzmeowww @jayehernandez Yes just checked the number of JSON files inside server/data/words and there are 16 in master so I will change the currentLanguagesCount to 17 in my pull request. |
@kvharish thanks for noticing this!! |
Hi, @jayehernandez @itzmeowww I also noticed that the Thailand flag has a typo in the README.md file so I have raised a new pull request #381 to fix it. |
@kvharish Thanks 😁 |
✅ New Language Checklist
server/data/languages.json
file.{language.json}
file inside theserver/data/words
folder containing the list of the 3000 words.currentLanguagesCount
inclient/src/store/index.js
README.md