Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thai language #336

Merged
merged 6 commits into from
Oct 4, 2020
Merged

Add thai language #336

merged 6 commits into from
Oct 4, 2020

Conversation

itzmeowww
Copy link
Contributor

@itzmeowww itzmeowww commented Oct 2, 2020

✅ New Language Checklist

  • There is ❌ no assigned issue or pull request for this new language.
  • ➕ Added a new JSON object in the server/data/languages.json file.
  • Added the voice 🎤 attribute supported by ResponsiveVoice API.
  • Added the flag 🏳 attribute in the format of the twemoji-awesome CSS syntax.
  • Added the romanization attribute for appropriate languages.
  • ➕ Created the {language.json} file inside the server/data/words folder containing the list of the 3000 words.
  • Removed duplicates and noted 🗒 them in the Pull Request.
  • Increment currentLanguagesCount in client/src/store/index.js
  • Add new language in README.md

@itzmeowww itzmeowww closed this Oct 2, 2020
@itzmeowww itzmeowww reopened this Oct 2, 2020
@itzmeowww
Copy link
Contributor Author

itzmeowww commented Oct 2, 2020

🌍 Add a Language #1

@itzmeowww
Copy link
Contributor Author

Can anyone help me with the check fail (🚥 Test / build (pull_request))

@Kvaibhav01
Copy link
Contributor

Hey, @itzmeowww take a look at this log. There seems to be some issue with the response variable in the index.js file.

@itzmeowww
Copy link
Contributor Author

@Kvaibhav01 Thanks, it was caused by my text formatting. 😄

@itzmeowww itzmeowww closed this Oct 2, 2020
@itzmeowww itzmeowww reopened this Oct 2, 2020
Copy link
Owner

@jayehernandez jayehernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this out, @itzmeowww! Just wondering about the changes in the README file aside from adding Thai to the supported languages? It's causing some merge conflicts

@itzmeowww
Copy link
Contributor Author

Thanks for starting this out, @itzmeowww! Just wondering about the changes in the README file aside from adding Thai to the supported languages? It's causing some merge conflicts

Ohh, I will try to fix it.

@itzmeowww
Copy link
Contributor Author

@jayehernandez I think it is caused by the ALL-CONTRIBUTORS-BADGE part.

@jayehernandez
Copy link
Owner

Thank you for contributing to Letra ☀️, @itzmeowww!! Appreciate your contribution to this open source project. 🥳

I'll be including the addition of Thai in the next release!


Continue supporting Letra by:

@jayehernandez jayehernandez merged commit ca1f142 into jayehernandez:master Oct 4, 2020
@jayehernandez jayehernandez linked an issue Oct 4, 2020 that may be closed by this pull request
@jayehernandez
Copy link
Owner

@all-contributors please add @itzmeowww for translation

@allcontributors
Copy link
Contributor

@jayehernandez

I've put up a pull request to add @itzmeowww! 🎉

@kvharish
Copy link
Contributor

kvharish commented Oct 4, 2020

Hi, @itzmeowww @jayehernandez I think incrementing the currentLanguagesCount is not done as part of this pull request. Could you please confirm? So that I can make the relevant change for the Tamil language pull request #376

@kvharish
Copy link
Contributor

kvharish commented Oct 4, 2020

@itzmeowww @jayehernandez Yes just checked the number of JSON files inside server/data/words and there are 16 in master so I will change the currentLanguagesCount to 17 in my pull request.

@jayehernandez
Copy link
Owner

@kvharish thanks for noticing this!!

@kvharish
Copy link
Contributor

kvharish commented Oct 4, 2020

Hi, @jayehernandez @itzmeowww I also noticed that the Thailand flag has a typo in the README.md file so I have raised a new pull request #381 to fix it.

@itzmeowww
Copy link
Contributor Author

@kvharish Thanks 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌍 Add a Language
4 participants