New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for Flag view #362

Merged

jayehernandez merged 1 commit into jayehernandez:master from hjades:letra-test-flag

Oct 4, 2020

hjades commented Oct 3, 2020

Added unit test for Flag View
Test cases:

it displays the correct flag
it displays the correct language name
it displays language name only when flag is on hover

Referencing test issue #124


          Add unit test for Flag view

6be6e99

jayehernandez approved these changes

View reviewed changes

jayehernandez merged commit 669b098 into jayehernandez:master

Owner

jayehernandez commented Oct 4, 2020

Thank you for contributing to Letra ☀️, @hjades !! Appreciate your contribution to this open source project. 🥳

@all-contributors please add @hjades for testing

Continue supporting Letra by:

Leaving a star ⭐️ for this GitHub repository
Downloading the free Chrome extension and leaving a review
Upvoting the ProductHunt page

allcontributors bot mentioned this pull request

docs: add hjades as a contributor #373

Merged

Contributor

allcontributors bot commented Oct 4, 2020

I've put up a pull request to add @hjades! 🎉

Author

hjades commented Oct 4, 2020

@jayehernandez yeah, thank you! Happy that i can contribute 😃
Can I add other unit tests? Also I noticed a Vue warn on this unit test, and I'd like to fix it 🙆🏼‍♀️

hjades deleted the letra-test-flag branch

October 4, 2020 06:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet