Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for Word view #383

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

hjades
Copy link

@hjades hjades commented Oct 4, 2020

Added unit test for Word view
Test cases:

  • it renders ellipsis when loading is true
  • when loading is false
    • it renders daily word
    • it renders word, translation, and romanization correctly
    • it renders quote and author
  • calculateFontSizeForDailyWord returns correct value

Also fix Vue warn in Flag.test.js
圖片

Referencing test issue: #124

@@ -9,7 +9,7 @@
h3.mb0 {{ dailyData.word.romanization || '' }}
.is-flex.is-justify-centered
h1(
v-bind:style="{ 'font-size': calcualteFontSizeForDailyWord }"
v-bind:style="{ 'font-size': calculateFontSizeForDailyWord }"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for changing this!

@jayehernandez
Copy link
Owner

Thank you for contributing to Letra ☀️, @hjades!! Appreciate your contribution to this open source project. 🥳


Continue supporting Letra by:

@jayehernandez jayehernandez merged commit 97c6385 into jayehernandez:master Oct 9, 2020
@jayehernandez
Copy link
Owner

@all-contributors please add @hjades for testing

@allcontributors
Copy link
Contributor

@jayehernandez

I've put up a pull request to add @hjades! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants