New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create greek.json #406

Closed

raven-wills wants to merge 4 commits into jayehernandez:master from raven-wills:patch-1

raven-wills commented Oct 7, 2020 •

edited

Loading

✅ New Language Checklist

There is ❌ no assigned issue or pull request for this new language.
➕ Added a new JSON object in the server/data/languages.json file.
Added the voice 🎤 attribute supported by ResponsiveVoice API.
Added the flag 🏳 attribute in the format of the twemoji-awesome CSS syntax.
Added the romanization attribute for appropriate languages.
➕ Created the {language.json} file inside the server/data/words folder containing the list of the 3000 words.
Removed duplicates and noted 🗒 them in the Pull Request.
Increment currentLanguagesCount in client/src/store/index.js
Add new language in README.md

raven-wills added 4 commits

October 7, 2020 14:04


          Create greek.json


          Update languages.json

34f53b7


          Update index.js

93910cc


          Update README.md

08b1828

Owner

jayehernandez commented Oct 11, 2020

Hey @raven-wills, sorry about this but this is already being worked on in #417, which is why I advised in #1 to comment there so I can assign the issue to someone. In line with this too, are you a native Greek speaker?

Author

raven-wills commented Oct 13, 2020

Hey @jayehernandez! Sorry I missed that PR, I'll defer to the work being done there.

raven-wills closed this

raven-wills deleted the patch-1 branch

October 13, 2020 01:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet