New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved test for Time view (100%) #444

Merged

jayehernandez merged 2 commits into jayehernandez:master from bobsany16:unit-test

Oct 14, 2020

Contributor

bobsany16 commented Oct 12, 2020

Improved unit test for Time view related to issue #124 and PR #428

Changes:

I extracted date and time outside of setInterval() by declaring a method getDateTime() so that getNow() would call setInterval() which calls getDateTime().
Added 2 tests to check if date and time are rendered correctly and they did.
Coverage remains 100% for lines, functions, branches, and statements.

bobsany16 added 2 commits

October 12, 2020 14:26


          refactor: extracted dateTime outside setInterval

358a351


          tested rendered date, time successfully

b0bd01c

Owner

jayehernandez commented Oct 14, 2020

Awesome!! Glad you were able to figure it out, thank you for contributing again @bobsany16!!

jayehernandez merged commit e396a39 into jayehernandez:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet