Fix time and date tests in Time.test.js

[mtsknn]

I noticed that the current test "should render date and time correctly" is not actually testing that the date and time are formatted correctly. It's just testing that the input and output are the same because the expected values in Time.test.js are specified the same way as in Time.vue:

/* Time.vue */

// Calculate time in 12-hour format
const time = today.toLocaleTimeString([], {
  hour: '2-digit',
  minute: '2-digit',
});
this.computedTime = time;

// Compute date according to the current locale
const date = today.toLocaleDateString([], {
  year: 'numeric',
  month: 'long',
  day: 'numeric',
});
this.computedDate = date;

/* Time.test.js */

expect(wrapper.find('.time').text()).toBe(
  today.toLocaleTimeString([], {
    hour: '2-digit',
    minute: '2-digit',
  }),
);

expect(wrapper.find('.date').text()).toBe(
  today.toLocaleDateString([], {
    year: 'numeric',
    month: 'long',
    day: 'numeric',
  }),
);

So the tests are basically like this:

expect(
  today.toLocaleTimeString([], {
    hour: '2-digit',
    minute: '2-digit',
  })
).toBe(
  today.toLocaleTimeString([], {
    hour: '2-digit',
    minute: '2-digit',
  })
);

// + date test

Or basically like expect(foo()).toBe(foo()).

Testing that the input is the same as the output doesn't give any confidence/certainty that the values are formatted correctly.

Plus what if today.toLocaleTimeString(/* ... */) returned undefined for some reason? Then the test would be basically this:

expect(undefined).toBe(undefined);

That's not quite what we want to test, right? 🙂

In this PR I'm explicitly defining that the expected values are '01:23 PM' and 'March 10, 2020'. This way the tests will actually fail if the time and date are not correctly formatted.

---

I also removed an unnecessary line from Time.vue.

[jayehernandez]

Great work! I admit I'm not well-versed in testing myself, so your PR is of great help!

[jayehernandez]

References #124

[jayehernandez]

@all-contributors please add @mtsknn for testing

[allcontributors]

@jayehernandez

I've put up a pull request to add @mtsknn! 🎉

[bobsany16]

@mtsknn wow! I learned a lot from this since I wrote the tests 😅. Thanks so much! I tried to mock date before but I just couldn't make it work. However, i learned a new thing today!

[mtsknn]

@bobsany16, I'm so glad to hear that, thanks! 😊