Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust flag list layout to prevent content overflow #630

Conversation

Sanjay-Sahu-Bandla
Copy link

Problem:

When selecting numerous flags, the content in both the left-hand flags container and the right-hand flags selection dropdown overflows beyond the viewport, exceeding 100vh and 100vw respectively. This creates a cluttered and visually disruptive user experience.

Solution:

This pull request implements a fix for the content overflow issue by applying max-height and overflow properties to both left-hand, right-hand sections. This effectively prevents content from spilling outside the designated areas, ensuring a clean and functional interface regardless of the number of selected flags.

Visual Improvements:

Before and after screenshots are provided for clear comparison:

  • Before: (Attached screenshot showcasing the overflow issue)

letra-overflow-issue-highlight-count

  • After: (Attached screenshot showcasing the resolved overflow)

Screenshot from 2023-12-15 21-58-02

These changes improve the user experience by preventing content overflow and maintaining a consistent layout, even when numerous flags are selected.

Technical Details:

  • The fix is implemented using CSS and doesn't affect the existing functionality of the flag selection process.
  • Thorough testing on various screen sizes and browsers ensures consistent behavior across platforms.

Call to Action:

Your feedback on this pull request is valuable. I'm open to suggestions for further improvements and optimization.

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
letra-extension ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 4:59pm

Copy link

vercel bot commented Dec 15, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @jayehernandez on Vercel.

@jayehernandez first needs to authorize it.

Copy link

Hi there! This repository is currently not accepting new PRs. For more info, please check out our README. If you have any questions, please feel free to contact us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant