Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: specify file read encoding #301

Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix: specify file read encoding #301

merged 1 commit into from
Feb 23, 2022

Conversation

codepaws
Copy link
Contributor

Ran into #224 on creation. Explicitly setting the encoding on the file open seems to fix the problem

@chenrui333 chenrui333 changed the title File read encoding problem fix: specify file read encoding Feb 23, 2022
@chenrui333 chenrui333 merged commit db7ff0d into jayfk:master Feb 23, 2022
@chenrui333
Copy link
Collaborator

Thanks @codepaws!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codepaws @chenrui333