New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support old mobile safari #8

Open

psineur wants to merge 2 commits into jaystack:master from psineur:es5

psineur commented Mar 26, 2019 •

edited

Loading

Old Mobile Safari (like iOS 9) doesn't support const keyword in strict mode and has no window.fetch either.

Changes:

Fix unhandled exceptions on import (es5 target + libs for Promise/Dom)
Add polyfill for window.fetch

Test plan:

using old iPad Mini with iOS 9.3.2 & webpack dev-server
load website (universal web/electron react-app) containing electron-ga, observe it's not loading - throws in rendered.bundle due to const keywords
apply changes, install electron-ga-psineur package
app should load now
network dev tools tab should have google-analytics.com/batch when events are sent

psineur added 2 commits

March 26, 2019 14:37


          tsconfig: target es5 to support old mobile safari

557143c


          Add fetch polyfill

0b56590

psineur changed the title ~~tsconfig: target es5 to support old mobile safari~~ Support old mobile safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet