dev into main (virtual keyboard) #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 11, 2022 12:55
When move cursor with arrows it startted typing on the old line - now works good also add right path to favicon
endless movement of the cursor to the right makes it appear on the right side of the text with subsequent errors in typing - now fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Task: https://github.com/rolling-scopes-school/tasks/blob/master/tasks/virtual-keyboard/virtual-keyboard-en.md
2. Screenshot:
3. Deploy: https://jaysuno0.github.io/virtual-keyboard/
4. Done 10.05.2022 / deadline 10.05.2022
5. 100 - 108? Не уверен потому что есть сомнения в одном единственном пункте - пункте проверки на ошибки eslint. В одном месте в файле keyboard.js eslint ругается, что использую функции до объявления. Не нашёл инфу - грубая ли это ошибка, сколько баллов за такое снимается, всё таки hoisting в языке есть. Вот единственный момент, в остальном всё в порядке.