Move to PEP-451 style loader

[adamchainz]

Fixes #385.

[adamchainz]

I didn’t add a changelog note yet because that would conflict with #384.

[adamchainz]

A bonus of using this wrapping approach is that it should still work when the settings file is a frozen module, or otherwise provided by some special kind of module. I don’t believe that was supported before, because the old ConfigurationImporter forced using the plain ConfigurationLoader, which had no special logic for loading things.

[adamchainz]

Also changing this class into a PEP-451 compliant finder, and renaming it as such.

[adamchainz]

Tests are passing but codecov is failing, as noted on #384.

[uhurusurfa]

@washeck @pauloxnet Is this application still being maintained? Do you need more hands to manage the PR reviews etc?

[pauloxnet]

The project is maintained but I'm not using it on a daily basis anymore.
Any help for reviews are welcome. 🤗

[uhurusurfa]

@pauloxnet - ok. Please add me to the project. Also, who is responsible for making releases as it is of no use if PR's are merged but we cannot get new releases done.

[pauloxnet]

I'm one of the 3 "leads" of the project and I triggered the last release which is aligned with the latest commit. So no risk of PR merged and not released.

I suggest to you to open your PR or (better) review opened PRs you are more interested in, to help it to be ready to be merged (e.g. this PR has some failing checks).

More info about about the project (and how to join it) here: https://jazzband.co/projects/django-configurations

[pauloxnet]

I opened an issue about Codecov failings #390 (help needed)

[cclauss]

Please rebase now that tests are passing again.

[codecov]

Codecov Report

Attention: Patch coverage is 95.52239% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (f37ed87) to head (b8f66f7).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
configurations/importer.py	90.62%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   90.39%   90.75%   +0.35%     
==========================================
  Files          25       27       +2     
  Lines        1197     1211      +14     
  Branches       86       86              
==========================================
+ Hits         1082     1099      +17     
+ Misses         88       86       -2     
+ Partials       27       26       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[pauloxnet]

Please rebase now that tests are passing again.

@cclauss I tied to solve the conflict, but I can't do anything else here.

If Adam can't push this forward, you are free to open another PR base on this and solve all the conflict and test issue.

[cclauss]

Just whitespace issues.

checkqa/bin/flake8 .
  ./configurations/importer.py:147:1: W293 blank line contains whitespace
  ./configurations/importer.py:149:13: E303 too many blank lines (2)

[pauloxnet]

Just whitespace issues.``` checkqa/bin/flake8 . ./configurations/importer.py:147:1: W293 blank line contains whitespace ./configurations/importer.py:149:13: E303 too many blank lines (2)

Can you add code suggestions so I can try to accept those?

[uhurusurfa]

@adamchainz - can you add unit tests to achieve required code coverage?

[adamchainz]

Rebased.

@adamchainz - can you add unit tests to achieve required code coverage?

Done. The flagged code paths weren't actually tested before, either 😅 .

[uhurusurfa]

Awesome - thanks - looks like we just need the unused imports removed and it will pass.