Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Upgrade the release workflow to Python 3.13 #389

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 30, 2024

@cclauss cclauss changed the title GitHub Actions: Upgrade to Python 3.12 GitHub Actions: Upgrade the release workflow to Python 3.12 Sep 6, 2024
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

Welcome aboard ⛵️!

@uhurusurfa
Copy link
Contributor

@pauloxnet - do you have permissions to trigger a rerun of the tests for this PR now that the codecov issue has been resolved?

@cclauss
Copy link
Contributor Author

cclauss commented Nov 8, 2024

Perhaps drop Py38 and add Py313

@cclauss cclauss changed the title GitHub Actions: Upgrade the release workflow to Python 3.12 GitHub Actions: Upgrade the release workflow to Python 3.13 Nov 8, 2024
@uhurusurfa
Copy link
Contributor

Perhaps drop Py38 and add Py313

Sure - go ahead and make the change

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (711fa66) to head (9688dae).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          25       25           
  Lines        1197     1197           
  Branches      102       86   -16     
=======================================
  Hits         1082     1082           
  Misses         88       88           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pauloxnet
Copy link
Member

@pauloxnet - do you have permissions to trigger a rerun of the tests for this PR now that the codecov issue has been resolved?

I just did it, but Python 3.13 tests are failing.

@pauloxnet
Copy link
Member

Perhaps drop Py38 and add Py313

Yes, drop Python 3.8 which is EOL and update the PR title accordingly.

@uhurusurfa uhurusurfa merged commit 7f0f29d into jazzband:master Nov 8, 2024
10 checks passed
@cclauss cclauss deleted the patch-1 branch November 8, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants