Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage upload #391

Closed
wants to merge 5 commits into from
Closed

Fix coverage upload #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5512f59
Fix coverage upload
uhurusurfa Oct 28, 2024
18cc93e
Try get more info on failure
uhurusurfa Oct 28, 2024
f35f681
See if additional DB URL test is affecting the outcome
uhurusurfa Oct 28, 2024
b30eecb
Switch order of comparison
uhurusurfa Oct 28, 2024
87093d4
Compare the embedded dicts to get the diff
uhurusurfa Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ jobs:
tox --verbose

- name: Upload coverage
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
name: Python ${{ matrix.python-version }}
name: coverage-data-${{ matrix.python-version }}
path: ".coverage.*"
include-hidden-files: true
merge-multiple: true
fail_ci_if_error: true
8 changes: 4 additions & 4 deletions tests/test_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,8 @@ def test_database_url_value(self):
value = DatabaseURLValue()
self.assertEqual(value.default, {})
with env(DATABASE_URL='sqlite://'):
self.assertEqual(value.setup('DATABASE_URL'), {
'default': {
settings_value = value.setup('DATABASE_URL')
self.assertDictEqual({
'CONN_HEALTH_CHECKS': False,
'CONN_MAX_AGE': 0,
'ENGINE': 'django.db.backends.sqlite3',
Expand All @@ -383,7 +383,7 @@ def test_database_url_value(self):
'PASSWORD': '',
'PORT': '',
'USER': '',
}})
}, settings_value['default'])

def test_database_url_additional_args(self):

Expand All @@ -395,7 +395,7 @@ def mock_database_url_caster(self, url, engine=None):
value = DatabaseURLValue(
engine='django_mysqlpool.backends.mysqlpool')
with env(DATABASE_URL='sqlite://'):
self.assertEqual(value.setup('DATABASE_URL'), {
self.assertDictEqual(value.setup('DATABASE_URL'), {
'default': {
'URL': 'sqlite://',
'ENGINE': 'django_mysqlpool.backends.mysqlpool'
Expand Down
Loading