Refactor cookiebar JS #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 96.77% 94.97% -1.81%
==========================================
Files 25 12 -13
Lines 714 398 -316
Branches 0 64 +64
==========================================
- Hits 691 378 -313
+ Misses 23 15 -8
- Partials 0 5 +5 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 6, 2023
Closed
There are essentially two main flows to the cookie consent bar that logically follow each other with normal use: 1. The user is new and hasn't accepted or declined any cookie groups, or new cookie groups were added that were previously unseen. When the user accepts/declines those cookie groups, the onAccept or onDeclined callback needs to execute for those cookie groups. 2. The user has previously accepted or declined cookies, but the associated (tracking/analytics) scripts are only loaded/activated conditionally (or deactivated with opt-out). The user already consented, so this should also call the onAccept/onDeclined callbacks with the relevant cookie groups. Of course, developers can use the template tags to conditionally emit certain scripts, but that gets in the way of aggressive page/ template caching and is the reason why the original JS solution isn't useful in those situations.
This helps enforce that the Javascript works correctly and *keeps* working correctly.
sergei-maertens
commented
Sep 21, 2023
Tests themselves should not be included in coverage stats, and really only the application itself is relevant.
This was referenced Sep 24, 2023
|
Can't really do much about the coverage drop because of the tests themselves being excluded from coverage reporting, so I'm merging this as-is and I'll release a beta version. |
This was referenced Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99